Skip to content

Subscriptions management - add unsusbscribe cell #103374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Subscriptions management - add unsusbscribe cell #103374

merged 1 commit into from
May 14, 2025

Conversation

Addison-Stavlo
Copy link
Contributor

Part of # p1747117057126739/1747074984.370769-slack-C03NLNTPZ2T / https://linear.app/a8c/issue/CML-380/one-click-unsubscribe

Proposed Changes

Add an unsubscribe cell to subscriptions management. The unsubscribe action needs to be more prominent for people who click newsletter emails to manage/unsubscribe both logged in and logged out.

AFTER
Screenshot 2025-05-13 at 11 33 01 AM

Why are these changes being made?

  • The unsubscribe action needs to be more prominent for people who click newsletter emails to manage/unsubscribe both logged in and logged out.

Testing Instructions

  • Go to subscribers management
  • Verify there is an "unsubscribe" button in the row.
  • Verify it works to unsubscribe.
  • Verify it fits well at various viewport widths.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-144012
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-144012&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-144012&env=a8c-for-agencies

@Addison-Stavlo Addison-Stavlo self-assigned this May 13, 2025
@Addison-Stavlo Addison-Stavlo added the [Linear] Loop Way to assign issues to Loop team in Linear label May 13, 2025
@Addison-Stavlo Addison-Stavlo requested a review from a team May 13, 2025 09:48
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 13, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/unsubcribe-row-subscriptions-management on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~61 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-subscriptions       +325 B  (+0.0%)      +61 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~59 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
reader       +325 B  (+0.0%)      +59 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

davemart-in
davemart-in approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@davemart-in davemart-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good for me.

@Addison-Stavlo Addison-Stavlo merged commit e6301fa into trunk May 14, 2025
16 of 17 checks passed
@Addison-Stavlo Addison-Stavlo deleted the add/unsubcribe-row-subscriptions-management branch May 14, 2025 11:52
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemart-in davemart-in davemart-in approved these changes

Assignees

@Addison-Stavlo Addison-Stavlo

Labels
[Linear] Loop Way to assign issues to Loop team in Linear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Addison-Stavlo @matticbot @davemart-in